Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
Snapshot-heavy PRs are effectively unreviewable on GitHub: the Files tab won't render diffs for hundreds of binary files, and a Playwright bump or a branch sync touches thousands. Reviewers end up opening screenshots one at a time or skipping them.
What is the new behavior?
A local app that reads each screenshot's before and after straight out of git, with no checkout, and serves them for review.
Does this introduce a breaking change?
Other information
To try it, clone this repo next to ionic-framework, run
npm ci, thennpm start -- --pr 31435for a quick 51-screenshot pass, ornpm start -- --pr 31465for every case the reviewer handles (renames, removals, orphans, re-encodes, existing comments).Both PRs are merged, so "Post comments" is disabled for them. Marking files viewed is safe.
Hosted Vercel previews, so a review doesn't need a local clone, will be looked into separately.