Skip to content

Add docstrings to API - #112

Open
Yannicked wants to merge 2 commits into
iterorganization:developfrom
Yannicked:feature/api-docstrings
Open

Add docstrings to API#112
Yannicked wants to merge 2 commits into
iterorganization:developfrom
Yannicked:feature/api-docstrings

Conversation

@Yannicked

Copy link
Copy Markdown
Collaborator

This adds docstrings to the existing API endpoints. These are displayed in the generated swagger documentation

@olivhoenen olivhoenen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this is much appreciated! Please just simplify the one case I found with duplication of into between endpoint level and its argument description.

Image

constraint = parse_query_arg(value)
if constraint[0] or constraint[1] == QueryType.EXIST:
constraints.append((name, *constraint))
"""List simulations, optionally filtered by metadata.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the description here enters too much into details as is a duplication of info w.r.t parameters you describe in line 172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants