Conversation
Preserve transcoding lifecycle integration and replace committed TLS fixtures with ephemeral test certificates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses stremio-native#34 by making the
/proxyroute failclosed against SSRF, DNS rebinding, credential leakage, recursive self-proxying,
and unbounded response/playlist resource use while preserving the installed
Stremio Server 4.20.15 proxy contract where it is safe.
This PR:
every redirect hop;
by default, including mapped IPv4, NAT64/Pref64, scoped IPv6, and mixed-answer
bypasses;
upstream TLS certificates, exposed through the tray/GUI, API, settings file,
and environment variables;
safe raw/effective settings persistence;
origins, pins a no-proxy client, and prevents public caching of credentialed
responses;
per-peer/global admission, read-idle, response-header, collection, delivery,
and downstream-stall lifetimes;
installed playlist line delimiters;
opaque crash dumps from exported ZIP files;
differences, and residual risks in
docs/network-source-security.md.Secure defaults and intentional differences
Private/LAN destinations and invalid upstream TLS certificates remain disabled
by default. Metadata and the server's own listeners are always denied. Cross-
origin redirects discard every caller-supplied custom request header, not only
the legacy credential names. RFC redirect method semantics and RFC-relative URL
resolution replace observable legacy bugs. Rewritten playlists are limited to
complete transformable
200representations; partial orno-transformresponses stream unchanged.
The application-layer policy is intentionally scoped to
/proxy; it does notclaim to secure every outbound URL sink or make the unauthenticated service safe
for public exposure. It does not alter Windows Firewall rules.
Verification
Final verification at exact head
8b414273435a2bb2e4d6287079880ee9d52633f1:33112228438passed Linux libtorrent and librqbit workspacechecks, strict Clippy, and tests in 15m12s;
shutdown testing in 16m55s;
394 server tests passed; the test-only bounded-wait correction is included in
the final green run;
scans passed;
maintenance/unsoundness warnings;
HTTPS tests now generate fresh self-signed certificate/key pairs in temporary
directories;
Critical, Important, or Minor findings.
Related dependency PR
Dependency modernization remains intentionally separate in
stremio-native#36. This fork branch incorporates that dependency
baseline through fork
master; the proxy hardening and dependency modernizationremain separate upstream review units and both are expected to land.
Scope
This PR targets
jahvari/stream-server:masteronly. It does not create, update,merge, or close an upstream branch or PR.