Skip to content

fix: onError getting passed Error objects instead of strings #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamestitus299 merged 1 commit into from
Sep 1, 2026
Merged

fix: onError getting passed Error objects instead of strings #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/builder/entry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ export function importLines(referencedGlobals: string[]): string {
// whether or not the source ever spells `React`.
if (name === "React") continue;

// Not a real export of any package -- callers are expected to strip
// <EditableText> back to plain JSX before reaching here.
if (name === "EditableText") continue;

if (name in baseScope) {
add(
name === "Helmet" || name === "HelmetProvider"
Expand Down
5 changes: 2 additions & 3 deletions src/builder/standalone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,11 @@ export async function buildStandaloneSite(
const source = await stripEditableText(code);
const entry = await entryFor(source);

const [js, css] = await Promise.all([
const [js, css, markup] = await Promise.all([
bundleEntry(entry, options),
compileCss(source, options),
prerender ? prerenderMarkup(source) : Promise.resolve(""),
]);

const markup = prerender ? await prerenderMarkup(source) : "";
const { head: hoisted, body } = splitHoisted(markup);

const files: Record<string, string> = {};
Expand Down
4 changes: 2 additions & 2 deletions src/coreComponents/EditReactCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default function EditReactCanvas({
// if error - onError callback if exist, return
if (error) {
if (onError) {
onError(error);
onError(error instanceof Error ? error.message : String(error));
}
return
}
Expand Down Expand Up @@ -157,7 +157,7 @@ export default function EditReactCanvas({
var { transformedCode, error } = transformEditableTextToJSX(transformedCode);
if (error) {
if (onError) {
onError(error);
onError(error instanceof Error ? error.message : String(error));
}
return
}
Expand Down