You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🤖 AI: In a tree that has already built in place, the ui_*.h left in the project root take precedence over the new ones: INCPATH lists -I. before -Iui, and qmake's dependency scan binds to the root copy — after qmake on this branch, all 76 generated-header dependency entries in Makefile.Release name the root files, none name ui/. A .ui edit then recompiles nothing, and the linked binary still carries the pre-edit strings while the regenerated ui/ui_aboutdlgbase.h carries the new one (Linux, Qt 5.15.13, g++). The same rebinding and the same -I./-Iui order appear on macOS with Qt 5.15.2 and clang. Pinned at e13e013.
Nothing clears the leftovers now: compiler_uic_clean lists only ui/ui_*.h, so make clean and make distclean skip them, and .gitignore keeps them out of git status. One rm ui_*.h fixes a tree permanently — worth a line in the PR description or the CHANGELOG entry, since in-place builds are exactly what this declutters.
Reproduce: build main in place, check out this branch, run qmake, then grep -cE '^[[:space:]]+ui_[a-z]+\.h' Makefile.Release gives 76 and the same pattern with ui/ui_ gives 0; on a fresh clone the two counts are 0 and 76.
Also ui/ in .gitignore is unanchored, so it ignores any nested ui directory, src/ui/ included; /ui/ would scope it to the build output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Update
Jamulus.proto store the generatedui_*.hfiles in their ownuidirectory instead of letting them clutter up the project root.CHANGELOG: Build: Use a separate ui directory for generated ui header files.
Context: Fixes an issue?
No, just helps keep the project root cleaner
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested and ready
What is missing until this pull request can be merged?
Review
Checklist