Repository navigation
mono - chore: remove sharp override - #441
Merged
Merged
Conversation
miniflare 5.20261019.0-beta resolves sharp 0.35.5 without the floor, so the pin no longer changes the lockfile. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 406 406
Branches 94 94
=========================================
Hits 406 406 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore. Removes a pnpm override that no longer changes the resolved version. No application code changes, so no new tests.
Summary
Remove the
sharpoverride. After thewranglerupgrade,miniflare@5.20261019.0-betaresolvessharp@0.35.5on its own, which meets the old floor>=0.35.5 <0.36. The lockfile package version does not change.undici@7still falls back to 7.29.1 and 7.30.1 without its pin, and>=8.12.2still resolves only 8.12.2, so that override stays.Changes
sharp: ">=0.35.5 <0.36"frompnpm-workspace.yamland the lockfile override snapshotsharp@0.35.4Verification
pnpm why sharpresolvessharp@0.35.5fromminiflarepnpm build && pnpm test— 239 tests, 100% coverage