Repository navigation
fix: security - markdown-it 15.0.3 (CVE-2026-111758) - #450
Merged
Merged
Conversation
Bump @jaredwray/fumanchu to 4.7.5 so every markdown-it copy resolves to 15.0.3. Exclude only that exact fumanchu release from the 7-day cooldown. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 438 438
Branches 102 102
=========================================
Hits 438 438 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Security fix. No application code changes. The existing suite still passes at 100% coverage.
Summary
Refresh the lockfile so the only
markdown-itcopy resolves to 15.0.3.writr6.1.6 anddocula3.0.2 are already the newest published releases, and neither pullsmarkdown-ititself. The vulnerable copy comes from@jaredwray/fumanchu.braces@3.0.3andhttp-cache-semantics@4.2.0are unchanged; neither has a published fix.No other
markdown-itpin exists in this repo (no other lockfile, Dockerfile, or CI config).@jaredwray/fumanchumarkdown-it@^15.0.3. Direct range inpackage.jsonis now^4.7.5. Nestedecto@5.1.1(viadocula@3.0.2) requests^4.7.3, so it resolves to the same 4.7.5 copy. No override.markdown-itchrono-nodechrono-node@2.10.3. Published 2026-10-12, outside the cooldown.argparsemarkdown-it@15.0.3depends on it. Published 2026-10-15, outside the cooldown.entitiesmarkdown-it@15.0.3depends onentities@^8.1.0. The existingentities@8.0.0copy stays for other parents. Published 2026-09-07.minimumReleaseAgeExclude
Needs Jared's sign-off.
minimumReleaseAgeis 10080 minutes (7 days) withminimumReleaseAgeStrict: true.@jaredwray/fumanchu@4.7.5was published 2026-10-26, so it is inside the cooldown. One exact-version entry was added inpnpm-workspace.yaml:@jaredwray/fumanchu@4.7.5markdown-it@15.0.3(published 2026-10-16) is outside the cooldown, so it has no exclude. No otherminimumReleaseAgeExcludeentries were added.DEFENSE_IN_DEPTH.mdrecords this exception as still needing sign-off.Test plan
pnpm why markdown-itshows onlymarkdown-it@15.0.3via@jaredwray/fumanchu@4.7.5(root and nestedecto@5.1.1throughdocula).braces@3.0.3andhttp-cache-semantics@4.2.0stay put.pnpm install --frozen-lockfile,pnpm build, andpnpm teston Node 22.22.2 — 261 tests, 100% coverage.tests (22),tests (24),tests (26), andcode-coveragepassed on this PR.