Add sorted set functions to RedisCache#673
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=========================================
+ Coverage 60.0% 83.6% +23.6%
=========================================
Files 39 21 -18
Lines 2534 1181 -1353
Branches 69 0 -69
=========================================
- Hits 1520 987 -533
+ Misses 1001 194 -807
+ Partials 13 0 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WisdomPill
left a comment
There was a problem hiding this comment.
nice effort but I see no tests nor changelog and I am afraid that without those this PR can't be merged
for more information, see https://pre-commit.ci
|
This has mostly been superseded by #798, however @oliverhaas it looks like you (and your AI) have forgotten the z*lex methods and zrevrank. As I suggested in #804, if you have a chance can you open a PR that adds the test I was asking for in #804, but for the sorted set methods? Alternatively, @Nazhixx you could do the same and contribute your changes to the mixin, but since you didn't respond to @WisdomPill I'm assuming you either missed the message or were uninterested in getting this PR over the fence. |
See #798
|
No description provided.