Skip to content

Add sorted set functions to RedisCache#673

Open
Nazhixx wants to merge 3 commits into
jazzband:masterfrom
Nazhixx:master
Open

Add sorted set functions to RedisCache#673
Nazhixx wants to merge 3 commits into
jazzband:masterfrom
Nazhixx:master

Conversation

@Nazhixx

@Nazhixx Nazhixx commented Jul 22, 2023

Copy link
Copy Markdown

No description provided.

@codecov

codecov Bot commented Jul 22, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.6%. Comparing base (0756a8b) to head (d303159).
⚠️ Report is 253 commits behind head on master.

Files with missing lines Patch % Lines
django_redis/client/default.py 20.0% 68 Missing ⚠️
django_redis/cache.py 66.7% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #673      +/-   ##
=========================================
+ Coverage    60.0%   83.6%   +23.6%     
=========================================
  Files          39      21      -18     
  Lines        2534    1181    -1353     
  Branches       69       0      -69     
=========================================
- Hits         1520     987     -533     
+ Misses       1001     194     -807     
+ Partials       13       0      -13     
Flag Coverage Δ
mypy ?
tests 83.6% <37.5%> (-5.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WisdomPill WisdomPill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice effort but I see no tests nor changelog and I am afraid that without those this PR can't be merged

@terencehonles

Copy link
Copy Markdown
Contributor

This has mostly been superseded by #798, however @oliverhaas it looks like you (and your AI) have forgotten the z*lex methods and zrevrank. As I suggested in #804, if you have a chance can you open a PR that adds the test I was asking for in #804, but for the sorted set methods?

Alternatively, @Nazhixx you could do the same and contribute your changes to the mixin, but since you didn't respond to @WisdomPill I'm assuming you either missed the message or were uninterested in getting this PR over the fence.

@oliverhaas

oliverhaas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@oliverhaas it looks like you (and your AI) have forgotten the z*lex methods and zrevrank.

See #798

I can also add more commands to this PR or in a next PR for sorted sets, but these are the main ones I would say, and I'm trying to not blow this up too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants