Skip to content

refactor: extract set operations into SetMixin#803

Draft
oliverhaas wants to merge 3 commits into
jazzband:masterfrom
oliverhaas:refactor/set-operations-mixin
Draft

refactor: extract set operations into SetMixin#803
oliverhaas wants to merge 3 commits into
jazzband:masterfrom
oliverhaas:refactor/set-operations-mixin

Conversation

@oliverhaas

Copy link
Copy Markdown
Contributor

No description provided.

@terencehonles

Copy link
Copy Markdown
Contributor

Same as #804

@oliverhaas do you mind sync'ing master? You can probably use the --ours merge conflict resolve strategy and then run pre-commit until it's stable to fix changes due to ruff causing conflicts. That should get you most of the way and then you can look at the diff to see if there are other changes you need to make. Alternatively, and possibly easier, you can just move the methods again.

Once you have done so, can you add a test that runs a diff against the redis.commands.core class you are mirroring and ensure that all methods are implemented (possibly with an exclude/skip list for methods that don't make sense here or maybe need to be implemented later if there are many)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants