test(clap): preserve choices in external adopter probes - #1157
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
75b6cba to
4bb45f1
Compare
4bb45f1 to
8e526ba
Compare
e7a7590 to
198f5c1
Compare
|
Too many files changed for review (149 files, 100 file limit). Bypass the limit by tagging |
198f5c1 to
a7492f1
Compare
1cb1bdc to
a7492f1
Compare
a7492f1 to
21b48ce
Compare
21b48ce to
0aee704
Compare
0aee704 to
dd279f9
Compare
dd279f9 to
15af64f
Compare
15af64f to
6b34ec2
Compare
6b34ec2 to
0aeb9ad
Compare
d566978 to
a2c4ce4
Compare
29f6b1b to
88d7762
Compare
88d7762 to
fab400b
Compare
fab400b to
8f50a4d
Compare
8f50a4d to
57b2d31
Compare
57b2d31 to
4a97c25
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
4a97c25 to
adc47d5
Compare
adc47d5 to
1b62ecc
Compare
fc7355a to
bd2a1a9
Compare
bd2a1a9 to
e16dd51
Compare
e16dd51 to
52732fa
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 52732fa. Configure here.
52732fa to
53e4eb7
Compare

Replaces #1145, which GitHub closed when dependent branch refs temporarily matched during a restack. It retains the original external adopter probes and addresses the choice-alias review feedback with typed ValueEnum shadows.\n\n_This pull request was generated by Codex._
Note
Medium Risk
Changes argv token classification so declared digit shorts outrank negative-number values, which can alter parse results for CLIs that mix both. The rest is generated shadows, fixtures, and tests.
Overview
Pins three non-jdx clap CLIs (fd, tokei, starship) as captured KDL, typed shadows, and reduced probes, with remaining clap-bridge gaps recorded in
benches/external/README.md.The parser now treats an exact declared digit short (e.g. fd’s
-0) as a flag instead of a negative number, while undeclared forms like-1stay values whenallow_negative_numbersapplies.Generated shadows emit
ValueEnumtypes instead of stringchoices, and the mise shadow/tests now honorarg_required_else_helpon a bare invocation.Reviewed by Cursor Bugbot for commit df4693f. Bugbot is set up for automated code reviews on this repo. Configure here.