feat(complete): support shell alias registration - #1158
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7751ad1 to
ce773ba
Compare
ce773ba to
77b5402
Compare
77b5402 to
11afcb4
Compare
11afcb4 to
71903b1
Compare
71903b1 to
925b457
Compare
88c48a1 to
750419b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 750419b. Configure here.
88c48a1 to
5cca41d
Compare
5cca41d to
18cfabd
Compare
18cfabd to
2839c3c
Compare
2839c3c to
2c53ca4
Compare
ca73ffd to
95b3959
Compare
fb35a1d to
907066f
Compare
42ff905 to
d37a160
Compare
d37a160 to
89ebfe3
Compare
89ebfe3 to
be6b2c8
Compare
be6b2c8 to
3a7a49a
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
3a7a49a to
5528f09
Compare
5528f09 to
e95a993
Compare
3988450 to
f05095f
Compare
d26ed83 to
de54c61
Compare
de54c61 to
c403518
Compare

Replaces #1146, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._
Note
Low Risk
Additive completion-script generation only. Parsing and ordinary CLI behavior are unchanged; risk is limited to generated shell registration names.
Overview
Adds explicit shell-alias completion: generated scripts can register a short name like
mwhile the callback still runs the real binary (mise). This is a registration API, not alias discovery, so it does not depend on interactive alias expansion.script()now delegates toscript_for(bin, name, shell). Bash, zsh, fish, Nu, and PowerShell registernameand invokebin. The same split is exposed ascompletion_script_for_aliason derived CLIs and the embeddedAppAPI. Both the registered name and the invoked binary are asserted to be a single safe shell word.Reviewed by Cursor Bugbot for commit e454902. Bugbot is set up for automated code reviews on this repo. Configure here.