Skip to content

feat(spec): add deprecated config environment aliases - #1159

Merged
jdx merged 1 commit into
agent/completion-shell-aliasesfrom
agent/config-deprecated-env
Aug 21, 2026
Merged

feat(spec): add deprecated config environment aliases#1159
jdx merged 1 commit into
agent/completion-shell-aliasesfrom
agent/config-deprecated-env

Conversation

@jdx

@jdx jdx commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Replaces #1147, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._


Note

Medium Risk
Changes environment-layer precedence and warning behavior for settings, which can alter which value wins when both current and old variables are set. Coverage is strong, but this is user-visible config resolution.

Overview
Config props can now declare deprecated_env names separately from current env aliases. Current names stay ordered and win; deprecated names are consulted afterwards, emit a deprecation warning when they actually set a value, and show up in generated registries and docs.

The env layer prefers every current name (including a renamed setting that folds into the same target) over every deprecated alias. Unused deprecated names do not warn. When a deprecated alias is used, the message points at the replacement setting’s current env name, not the old key.

Reviewed by Cursor Bugbot for commit 584b159. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: db59d026-7228-497e-a6ae-45379d4f6cc0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx force-pushed the agent/config-deprecated-env branch from 0191317 to b21de5a Compare August 21, 2026 02:41
@jdx
jdx force-pushed the agent/config-deprecated-env branch from b21de5a to f6ff075 Compare August 21, 2026 02:43
@jdx
jdx force-pushed the agent/config-deprecated-env branch from f6ff075 to acf22d0 Compare August 21, 2026 02:47
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 284a11d to e7e4753 Compare August 21, 2026 03:21
@jdx
jdx force-pushed the agent/config-deprecated-env branch from e7e4753 to 423c819 Compare August 21, 2026 03:41
@jdx
jdx force-pushed the agent/config-deprecated-env branch from 423c819 to 14eda2d Compare August 21, 2026 03:43
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 423c819 to 995c870 Compare August 21, 2026 03:56
@jdx
jdx force-pushed the agent/config-deprecated-env branch from 995c870 to 2596392 Compare August 21, 2026 04:10
@jdx
jdx force-pushed the agent/config-deprecated-env branch from 2596392 to e3e575a Compare August 21, 2026 04:19
@jdx
jdx force-pushed the agent/config-deprecated-env branch from e3e575a to c19ef5a Compare August 21, 2026 04:31
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from cfa341a to cf92a1c Compare August 21, 2026 04:41
@jdx
jdx force-pushed the agent/config-deprecated-env branch from cf92a1c to cfa341a Compare August 21, 2026 04:43
@jdx
jdx force-pushed the agent/config-deprecated-env branch from af77fb7 to 01f9d88 Compare August 21, 2026 06:08
@jdx
jdx force-pushed the agent/config-deprecated-env branch from 01f9d88 to b17d22c Compare August 21, 2026 06:11
@jdx
jdx force-pushed the agent/config-deprecated-env branch from b17d22c to b31aa54 Compare August 21, 2026 06:23
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 5be31db to c494b01 Compare August 21, 2026 06:46
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 85c54d5 to 9da6612 Compare August 21, 2026 07:10
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 737c38e to b791169 Compare August 21, 2026 07:30
@jdx
jdx force-pushed the agent/config-deprecated-env branch from b791169 to 9c22c79 Compare August 21, 2026 07:49
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 8045590 to abb95c1 Compare August 21, 2026 08:16
@jdx
jdx force-pushed the agent/config-deprecated-env branch 2 times, most recently from 927e063 to bebb470 Compare August 21, 2026 08:26
@jdx
jdx force-pushed the agent/config-deprecated-env branch from bebb470 to f1186b4 Compare August 21, 2026 08:32
@github-actions

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
markdown ▁██ 226,081,956 → 226,116,539 +0.02% 22.17 → 20.67ms -6.76%
startup ▁▇█ 1,226,955 → 1,227,348 +0.03% 1.43 → 1.41ms -1.40%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

Shadow comparison

Parsing mise use -g node@20 against a shadow of mise's committed spec.
Reported, not gated: the shadow grows as the derive learns to express more, so
what to watch is the ratio rather than either column.

framework instructions, cold parse vs usage
usage 8316
argh 6307 0.8x
clap 6316072 759x
bpaf 21909147 2634x
                                              min       p01       p10    median
usage-rs: argv -> struct                      408       411       414       419  ns
argh: argv -> struct                          288       291       295       305  ns
clap: build tree + parse -> struct         519714    520676    522158    525260  ns
bpaf: build parser + parse -> struct      1592188   1592188   1598900   1607382  ns

usage: argv -> struct                             453 ns      0.45 µs
clap: build tree + parse -> struct             529583 ns    529.58 µs
clap: parse -> struct, tree reused              22318 ns     22.32 µs
clap: build tree only                          326976 ns    326.98 µs

584b15941f60 vs e4549028527f · measured on the runner, not pushed to the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant