feat(spec): add deprecated config environment aliases - #1159
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0191317 to
b21de5a
Compare
b21de5a to
f6ff075
Compare
f6ff075 to
acf22d0
Compare
284a11d to
e7e4753
Compare
e7e4753 to
423c819
Compare
423c819 to
14eda2d
Compare
423c819 to
995c870
Compare
995c870 to
2596392
Compare
2596392 to
e3e575a
Compare
e3e575a to
c19ef5a
Compare
cfa341a to
cf92a1c
Compare
cf92a1c to
cfa341a
Compare
af77fb7 to
01f9d88
Compare
01f9d88 to
b17d22c
Compare
b17d22c to
b31aa54
Compare
5be31db to
c494b01
Compare
85c54d5 to
9da6612
Compare
737c38e to
b791169
Compare
b791169 to
9c22c79
Compare
8045590 to
abb95c1
Compare
927e063 to
bebb470
Compare
bebb470 to
f1186b4
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
Replaces #1147, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._
Note
Medium Risk
Changes environment-layer precedence and warning behavior for settings, which can alter which value wins when both current and old variables are set. Coverage is strong, but this is user-visible config resolution.
Overview
Config props can now declare
deprecated_envnames separately from currentenvaliases. Current names stay ordered and win; deprecated names are consulted afterwards, emit a deprecation warning when they actually set a value, and show up in generated registries and docs.The env layer prefers every current name (including a renamed setting that folds into the same target) over every deprecated alias. Unused deprecated names do not warn. When a deprecated alias is used, the message points at the replacement setting’s current env name, not the old key.
Reviewed by Cursor Bugbot for commit 584b159. Bugbot is set up for automated code reviews on this repo. Configure here.