Skip to content

test(clap): cover aliases and help metadata - #1160

Merged
jdx merged 1 commit into
agent/config-deprecated-envfrom
agent/clap-alias-conformance
Aug 21, 2026
Merged

test(clap): cover aliases and help metadata#1160
jdx merged 1 commit into
agent/config-deprecated-envfrom
agent/clap-alias-conformance

Conversation

@jdx

@jdx jdx commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Replaces #1148, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._


Note

Low Risk
Test-only and plan-doc updates; no parser, help, or completion implementation changes.

Overview
Extends the clap micro-conformance harness with two paired CLIs so usage and clap agree on alias binding, completion visibility, and help presentation.

aliases_and_case checks that visible and hidden flag/subcommand aliases parse the same values, that case-insensitive value aliases (FAST, quick) bind to the same enum variant, and that completions advertise only visible spellings.

help_metadata checks long help for custom subcommand headings and placeholders, flag help_heading, next_line_help layout, and that hidden flags/subcommands stay out of help. PLAN.md records these rows in the generated clap matrix.

Reviewed by Cursor Bugbot for commit 3c88304. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ae26690-7d83-47b3-88f6-df3f82a9ed6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 8f2b0cb to c21cd2a Compare August 21, 2026 02:41
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from c21cd2a to a8eff5e Compare August 21, 2026 02:43
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from a8eff5e to a22d9d0 Compare August 21, 2026 02:47
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from a22d9d0 to 7b11734 Compare August 21, 2026 03:17
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 7b11734 to 61a26d8 Compare August 21, 2026 03:21
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 3 times, most recently from 88b56c6 to c46b123 Compare August 21, 2026 03:49
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from 65b098e to 6afc291 Compare August 21, 2026 04:10
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 6afc291 to 8c9eb82 Compare August 21, 2026 04:19
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 8c9eb82 to 5ce815d Compare August 21, 2026 04:31
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from c4ce01e to dff6fee Compare August 21, 2026 04:41
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from dff6fee to c4ce01e Compare August 21, 2026 04:43
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from c4ce01e to 33871a1 Compare August 21, 2026 05:03
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from a62da18 to 9bc0fe7 Compare August 21, 2026 06:11
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from 29fadae to 601b05b Compare August 21, 2026 06:35
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Instruction counts

The comparison never ran — an earlier step failed.

3c88304d3cc5 vs `` · measured on the runner, not pushed to the history.

@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from 188ff7d to 8179a4b Compare August 21, 2026 06:56
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from 106c8e4 to c5133ea Compare August 21, 2026 07:23
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from c5133ea to 2f825ef Compare August 21, 2026 07:30
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 2f825ef to bb696c5 Compare August 21, 2026 07:49
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from bb696c5 to 7ac4628 Compare August 21, 2026 08:10
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 7ac4628 to 075f3aa Compare August 21, 2026 08:16
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 075f3aa to 22dd2d0 Compare August 21, 2026 08:25
@jdx
jdx force-pushed the agent/clap-alias-conformance branch from 22dd2d0 to b1f9dc2 Compare August 21, 2026 08:26
@jdx
jdx force-pushed the agent/clap-alias-conformance branch 2 times, most recently from 037694b to 9a718df Compare August 21, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant