fix(parse): honor separator after automatic args - #1164
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ab730ba to
0684565
Compare
0684565 to
27d5785
Compare
27d5785 to
64f0028
Compare
a988d23 to
ba0262c
Compare
3582ba9 to
8540519
Compare
3582ba9 to
f55d716
Compare
f55d716 to
8e52384
Compare
8e52384 to
4d82f13
Compare
4d82f13 to
7652717
Compare
4f950ff to
b3ec654
Compare
b3ec654 to
4f950ff
Compare
5a10899 to
726c794
Compare
726c794 to
9e55fea
Compare
9e55fea to
6172b4e
Compare
6172b4e to
580aec8
Compare
580aec8 to
f0913eb
Compare
f0913eb to
2c1a10f
Compare
2c1a10f to
8fb82af
Compare
8fb82af to
35ab5c4
Compare
35ab5c4 to
1806e33
Compare
51430e9 to
b2eb25c
Compare
abda55e to
7308c86
Compare
7308c86 to
5e7800b
Compare
Replaces #1152, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._
Note
Medium Risk
Changes argv
--semantics in both usage-argv and usage-lib, which can rebind nested passthrough command lines. Coverage is added, but this is core parser behavior.Overview
Fixes nested passthrough like
mise run wrapper -- command ...: anautomaticargument used to turn a later explicit--into data, so adouble_dash="required"field never unlocked and the wrapper received--as its executable.The first explicit separator now stays syntax after automatic flag stopping. Only a separator that has already been consumed makes later
--tokens ordinary values. The same rule is applied inusage-argvand usage-lib, and the misetasks rungate plus a newSplitconformance case assert both the typed parse and the emitted spec.Reviewed by Cursor Bugbot for commit afb08bf. Bugbot is set up for automated code reviews on this repo. Configure here.