Skip to content

fix(parse): honor separator after automatic args - #1164

Merged
jdx merged 1 commit into
agent/remaining-design-decisionsfrom
agent/automatic-required-separator
Aug 21, 2026
Merged

fix(parse): honor separator after automatic args#1164
jdx merged 1 commit into
agent/remaining-design-decisionsfrom
agent/automatic-required-separator

Conversation

@jdx

@jdx jdx commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Replaces #1152, which GitHub automatically marked merged when dependent branch refs temporarily matched during a restack. This is the same layer on the corrected stack.\n\n_This pull request was generated by Codex._


Note

Medium Risk
Changes argv -- semantics in both usage-argv and usage-lib, which can rebind nested passthrough command lines. Coverage is added, but this is core parser behavior.

Overview
Fixes nested passthrough like mise run wrapper -- command ...: an automatic argument used to turn a later explicit -- into data, so a double_dash="required" field never unlocked and the wrapper received -- as its executable.

The first explicit separator now stays syntax after automatic flag stopping. Only a separator that has already been consumed makes later -- tokens ordinary values. The same rule is applied in usage-argv and usage-lib, and the mise tasks run gate plus a new Split conformance case assert both the typed parse and the emitted spec.

Reviewed by Cursor Bugbot for commit afb08bf. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0cd3d91e-27e5-4fc3-926f-e2d4eface2f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx force-pushed the agent/automatic-required-separator branch from ab730ba to 0684565 Compare August 21, 2026 02:41
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 0684565 to 27d5785 Compare August 21, 2026 02:44
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 27d5785 to 64f0028 Compare August 21, 2026 02:47
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from a988d23 to ba0262c Compare August 21, 2026 03:21
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from 3582ba9 to 8540519 Compare August 21, 2026 03:43
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from 3582ba9 to f55d716 Compare August 21, 2026 03:56
@jdx
jdx force-pushed the agent/automatic-required-separator branch from f55d716 to 8e52384 Compare August 21, 2026 04:10
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 8e52384 to 4d82f13 Compare August 21, 2026 04:19
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 4d82f13 to 7652717 Compare August 21, 2026 04:31
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from 4f950ff to b3ec654 Compare August 21, 2026 04:41
@jdx
jdx force-pushed the agent/automatic-required-separator branch from b3ec654 to 4f950ff Compare August 21, 2026 04:43
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 5a10899 to 726c794 Compare August 21, 2026 06:12
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 726c794 to 9e55fea Compare August 21, 2026 06:23
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 9e55fea to 6172b4e Compare August 21, 2026 06:35
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 6172b4e to 580aec8 Compare August 21, 2026 06:46
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 580aec8 to f0913eb Compare August 21, 2026 06:56
@jdx
jdx force-pushed the agent/automatic-required-separator branch from f0913eb to 2c1a10f Compare August 21, 2026 07:10
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 2c1a10f to 8fb82af Compare August 21, 2026 07:23
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 8fb82af to 35ab5c4 Compare August 21, 2026 07:30
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 35ab5c4 to 1806e33 Compare August 21, 2026 07:49
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from 51430e9 to b2eb25c Compare August 21, 2026 08:16
@jdx
jdx force-pushed the agent/automatic-required-separator branch 2 times, most recently from abda55e to 7308c86 Compare August 21, 2026 08:26
@jdx
jdx force-pushed the agent/automatic-required-separator branch from 7308c86 to 5e7800b Compare August 21, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant