Document which commit a GitHub check is published against #333 - #539
Open
AzazelSensei wants to merge 1 commit into
Open
Document which commit a GitHub check is published against #333#539AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Git SCM jobs that check out refs/pull/*/merge publish the check on GitHub's merge commit, not the PR head. GitHub Branch Source already uses the pull head SHA. Fixes jenkinsci#333 Signed-off-by: Abdullah <89297042+AzazelSensei@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333
README now explains which SHA this plugin publishes a check against.
GitHub Branch Source already uses the pull request head, even when the job builds the merge into the target branch. Git SCM uses GIT_COMMIT, so origin/pull/N/merge posts the check on GitHub's merge commit instead of the PR head. There is no SHA override in this plugin; use origin/pull/N/head or GitHub Branch Source if the check needs to show on the PR.