Grouped dependency updates (#15-#19) on top of the org.json linkage fix - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups the five open dependabot PRs into one branch so they are tested together, on top of the
linkage fix from #14.
Contents
Each bump is byte-identical to its dependabot PR, including the pinned commit SHAs.
Why grouped, and why on top of #14
The dependabot PRs were each opened against master, so their CI ran without the guards #14 adds
(
PluginLinkageITandhpi.strictBundledArtifacts). Stacking them here means the bumps are validatedby those checks rather than landing beside them untested.
That matters most for the BOM bump. Before #14, the
org.jsonlinkage depended on a transitive pluginchain (
junit -> echarts-api -> jackson2-api -> json-api), and a BOM bump is exactly the kind ofchange that reshuffles those versions. With the dependency declared directly it can no longer break
that way — this PR is the first evidence of that holding.
Verification
mvn clean verifygreen: 35 unit tests + 3 integration tests. Specifically after the bumps:hpi.strictBundledArtifactsdoes not trip;PluginLinkageITpasses — no package moved out from under a declared dependency;json-apiandapache-httpcomponents-client-4-apistill resolve to the same versions.Not verified on a live Jenkins. The
NoClassDefFoundErrorpath from #14 still deserves a TestPublisher smoke test on a real instance before this is released.
Merging
This supersedes #14 and #15-#19; all six can be closed once this lands.