ci: run sonarcloud security on main#144
Merged
Merged
Conversation
The 'security with sonarcloud' job ignored main (and audit-only ran on main), so SonarCloud never scanned main — GitHub flags main's code-scanning results as out of date even though the code passed scanning as a PR. Move main out of both security filters: audit-only is now forked-PRs-only (/pull/N); with-sonarcloud now covers main, so main is scanned and results stay current. Signed-off-by: Jeremiah Russell <jerry@jrussell.ie>
Collaborator
✅ Commit Signature Verification - SuccessAll commits have been verified successfully. Summary
No impersonation attempts detected. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
jerusdp
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
security with sonarcloudjob ignoredmain(andsecurity audit onlyran on main), so SonarCloud never scannedmain. GitHub then flags main's code-scanning results as "may be out of date" — even though the same code passed scanning as a PR (PR-ref scans don't satisfy themainbranch).Fix
Move
mainout of both filters, matching the known-good shape (kdeets):security audit only→only: /pull\/[0-9]+/(forked PRs only — SonarCloud secrets/context aren't available there)security with sonarcloud→ignore: /pull\/[0-9]+/(everything else, including main + non-forked PRs)So
mainis scanned + uploaded on every push, keeping code-scanning/SonarCloud results current.CI-config-only change.