Skip to content

Service scan support - #1394

Open
attiasas wants to merge 13 commits into
jfrog:mainfrom
attiasas:service_scan_support
Open

Service scan support#1394
attiasas wants to merge 13 commits into
jfrog:mainfrom
attiasas:service_scan_support

Conversation

@attiasas

@attiasas attiasas commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Depends on:

Support scanning and reporting issues from Services (Missconfigurations) scan

image image

@attiasas attiasas added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jul 30, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Jul 30, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 2, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Aug 2, 2026
@attiasas attiasas mentioned this pull request Aug 2, 2026
4 tasks
@attiasas
attiasas requested a review from a team August 4, 2026 13:02
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 4, 2026
@attiasas

Copy link
Copy Markdown
Contributor Author

Addressing the remaining review notes:

Summary goldens only covering “Not Scanned” — updated TestScanSummaryContent fixtures and the summary goldens so Services is scanned and shows severity details (vulns / violations / both).

TestGetNewReviewComments Services case — already covered in the “With issues for review comments” case (ServicesVulnerabilities + expected ServicesComment), added in 5dcebdf before the review. Leaving it bundled with IaC/SAST rather than adding a dedicated case.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 16, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Aug 16, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 23, 2026
@attiasas
attiasas requested a review from a team August 23, 2026 07:08
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Aug 23, 2026
@jfrog jfrog deleted a comment from github-actions Bot Aug 23, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 27, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants