feat(client): control-limit gates for calendar, photo and weather management - #181
Merged
Merged
Conversation
Owner
|
I merged #180 so this needs a rebase. I would have run it myself if I wasn't on my phone. If I get to it before you do I'll run a merge conflict resolution on it and merge. |
…agement The core catalog covered chores only, so a display set to hide everything still offered the calendar gear (calendars, sync, display options), the day modal's Add event and each event's edit and delete, the photo gear (sources, picker, slideshow), and the weather gear. Four ids follow the guide's rule of hiding the gate rather than every button inside it: core:calendarSettings, core:editEvents, core:photoSettings and core:weatherSettings. Each widget closes an already-open popover or dialog when its id becomes hidden, as ChoreWidget does. Per the guide's retrofit note, a display on hideAll hides these on upgrade without anyone revisiting its settings.
mrramam
force-pushed
the
feat/core-control-gates
branch
from
September 17, 2026 00:49
d3d136a to
1518a9a
Compare
Contributor
Author
|
Forced a push, that should do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The core Control Limits catalog covered chores only, so a display set to Wall display still offered the calendar gear (calendars, sync, display options), the day modal's Add event and each event's edit and delete, the photo gear (sources, picker, slideshow) and the weather gear.
Four ids, following the guide's rule of hiding the gate rather than every button inside it:
core:calendarSettings,core:editEvents,core:photoSettings,core:weatherSettings. Each widget closes an already open popover or dialog when its id becomes hidden, as ChoreWidget does. Labels inenandes; the control-limits guide lists them; the catalog-size guard test now tracksCORE_CONTROLS.lengthinstead of hardcoding five.Per the guide's retrofit note, a display already on
hideAllhides these on upgrade without anyone revisiting its settings. That is the intended effect for a wall display, but worth knowing.Testing
Client: 302 tests,
check:i18n,vite build. Verified on ahideAlldisplay without a remembered PIN, then on our kitchen display since 2026-09-16.Touches the same three widget files as #180; happy to rebase whichever lands second.