Repository navigation
add reactive-engine - #16
Merged
johnsoncodehk merged 9 commits intoOct 14, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The npm lockfile required by CI is stale, and the adapter export contains a naming typo.
2 open findings
What changed in this PR
Adds @pravosleva/reactive-engine as the sixteenth framework in the reactive behavior test matrix.
Changes:
- Adds and registers a Reactive Engine adapter.
- Adds dependencies and generated Yarn lock data.
- Updates README results and framework metadata.
| File | Description |
|---|---|
package.json |
Adds Reactive Engine and RxJS dependencies. |
yarn.lock |
Locks the Yarn dependency graph. |
test/frameworks/reactiveEngine.ts |
Implements the framework adapter. |
test/frameworks/index.ts |
Registers the adapter. |
README.md |
Updates framework counts, versions, and results. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
added 2 commits
October 14, 2026 08:39
Contributor
Author
|
@johnsoncodehk could you please replace README file with @pravosleva/reactive-engine@2.2.0 (latest) ? Or need PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I would like to take part in your party.