test: reduce possibility of namespace collision in unit tests#860
Merged
mandre merged 1 commit intoJul 25, 2026
Merged
Conversation
Replace `GenerateName()` with client-side name generation using `utilrand.String(10)` for test namespaces. When using `GenerateName()`, it generates a new 5-char random suffix and the API server checks if that name exists. Envtest only runs kube-apiserver + etcd so namespaces marked for deletion are never actually cleaned up. On Kubernetes 1.29 (our envtest version, chosen as the minimum for CEL validation), the `RetryGenerateName` feature gate [1] doesn't exist yet (introduced in 1.30), so there are no retries and the collision is a hard failure. By setting Name directly with a locally-generated 10-char random string, we considerably increase the pool of possible names, making collisions practically impossible. [1] https://www.kubernetes.dev/resources/keps/4420/ Closes: k-orc#850
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
GenerateName()with client-side name generation usingutilrand.String(10)for test namespaces.When using
GenerateName(), it generates a new 5-char random suffix and the API server checks if that name exists. Envtest only runs kube-apiserver + etcd so namespaces marked for deletion are never actually cleaned up. On Kubernetes 1.29 (our envtest version, chosen as the minimum for CEL validation), theRetryGenerateNamefeature gate [1] doesn't exist yet (introduced in 1.30), so there are no retries and the collision is a hard failure.By setting Name directly with a locally-generated 10-char random string, we considerably increase the pool of possible names, making collisions practically impossible.
[1] https://www.kubernetes.dev/resources/keps/4420/
Closes: #850