Keystone: Implement Region controller#862
Open
gndrmnn wants to merge 10 commits into
Open
Conversation
$ go run ./cmd/scaffold-controller -interactive=false \
-kind=Region \
-gophercloud-client=NewIdentityV3 \
-gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/identity/v3/regions \
-gophercloud-type=Region \
-openstack-json-object=region
On-behalf-of: SAP nils.gondermann@sap.com
Register with the resource generator On-behalf-of: SAP nils.gondermann@sap.com
Add the OpenStack client to scope On-behalf-of: SAP nils.gondermann@sap.com
Register the controller On-behalf-of: SAP nils.gondermann@sap.com
On-behalf-of: SAP nils.gondermann@sap.com
On-behalf-of: SAP nils.gondermann@sap.com
dlaw4608
reviewed
Jul 23, 2026
On-behalf-of: SAP nils.gondermann@sap.com
On-behalf-of: SAP nils.gondermann@sap.com
Generate the OLM bundle On-behalf-of: SAP nils.gondermann@sap.com
On-behalf-of: SAP nils.gondermann@sap.com
gndrmnn
force-pushed
the
implement_region
branch
from
July 23, 2026 14:26
9fdcdd6 to
0c56e56
Compare
winiciusallan
left a comment
winiciusallan
left a comment
Member
There was a problem hiding this comment.
Hey @gndrmnn, great work! At a first glance, this looks very good to me. I left a few comments, but I'm still missing a review in the tests. Will do it later.
|
|
||
| // RegionResourceSpec contains the desired state of the resource. | ||
| type RegionResourceSpec struct { | ||
| // name will be the ID of the Region. |
Member
There was a problem hiding this comment.
Let's add this as a note and keep the doc more descriptive. Something like:
Suggested change
| // name will be the ID of the Region. | |
| // name is the name of the Region resource. This field will be passed as the region ID in the Keystone API. |
|
|
||
| // RegionResourceStatus represents the observed state of the resource. | ||
| type RegionResourceStatus struct { | ||
| // name is the ID for the resource. |
Member
There was a problem hiding this comment.
The same suggestion as from spec.name
| // RegionResourceSpec contains the desired state of the resource. | ||
| type RegionResourceSpec struct { | ||
| // name will be the ID of the Region. | ||
| // +required |
Member
There was a problem hiding this comment.
I think we can have this field optional and fallback to the k8s resource name, still using it as the RegionID. Wdyt?
| // so we must use client-side filtering. | ||
| filters := []osclients.ResourceFilter[osResourceT]{ | ||
| func(r *regions.Region) bool { | ||
| return r.ID == string(orcObject.Spec.Resource.Name) |
Member
There was a problem hiding this comment.
nit: you already have the resourceSpec stored in a variable. You can use:
Suggested change
| return r.ID == string(orcObject.Spec.Resource.Name) | |
| return r.ID == string(resourceSpec.Name) |
Comment on lines
+97
to
+105
| // TODO(scaffolding): Add more resource-specific validation tests. | ||
| // Some common things to test: | ||
| // - Immutability of fields with `self == oldSelf` validation | ||
| // - Enum validation (valid and invalid values) | ||
| // - Numeric range validation (min/max bounds) | ||
| // - Tag uniqueness (if the resource has tags with listType=set) | ||
| // - Format validation (CIDR, UUID, etc.) | ||
| // - Cross-field validation rules | ||
| }) |
Member
There was a problem hiding this comment.
Please, take a look at these. The code comment is very good wrt what you could implement here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regions are weird in that they have an
idfield, which is used as a name (no UUID) but they lack a propernamefield.I took the liberty to do a
name->idmapping in the actuator and status as I think that makes more sense form a k-orc perspective. Though if you want I can rename the field toidjust to be consistent with the upstream naming.