Skip to content

fix(python): consolidate API v2 startup validation - #2887

Open
tryambak2019 wants to merge 9 commits into
kagent-dev:mainfrom
tryambak2019:fix/2689-python-startup-consolidation
Open

tryambak2019 wants to merge 9 commits into
kagent-dev:mainfrom
tryambak2019:fix/2689-python-startup-consolidation

Conversation

@tryambak2019

Copy link
Copy Markdown
Contributor

Summary

Consolidates the related Python startup and documentation work requested in the review of #2832.

  • Corrects retained package and sample documentation to remove obsolete Kagent-owned session, controller, and persistence claims.
  • Restores installed sample entry points, Docker commands, ASGI construction, and GET /health coverage for currency, OpenAI, LangGraph, ADK, and CrewAI samples.
  • Runs the combined sample suite with import-safe test collection and prevents reintroduction of removed Kagent REST session APIs.

Supersedes #2821, #2829, #2830, #2831, #2832, and #2834. #2833 is already merged and is not included.

Related to #2689. This PR does not close #2689.

Validation

  • OPENAI_API_KEY=fake make -C python test: 586 passed, 1 skipped (Python 3.13)
  • Python test matrix completed on 3.11, 3.12, and 3.13
  • uv lock --check, Ruff format/lint, and git diff --check
  • Built and health-probed the seven retained sample images with placeholder runtime configuration.

Live A2A requests, Kubernetes/BYO deployment, and durable checkpoint/restart behavior remain unvalidated and are explicitly not claimed by this PR.

@tryambak2019

Copy link
Copy Markdown
Contributor Author

@supreme-gg-gg This is the combined replacement requested in #2832. It supersedes #2821, #2829-2832, and #2834; combined tests and sample health checks are included. Could you please review #2887?

@tryambak2019
tryambak2019 force-pushed the fix/2689-python-startup-consolidation branch from 31a9f1c to f24dec5 Compare September 25, 2026 19:55
@tryambak2019

tryambak2019 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

@dustinCodes84600 Addressed in f24dec58.

I updated the test to construct TestClient(captured["app"]) and assert /health returns OK. This verifies the captured object is a functional ASGI application, not just that it was passed to Uvicorn.

Could you please merge this when ready?

@tryambak2019
tryambak2019 force-pushed the fix/2689-python-startup-consolidation branch from f24dec5 to c4af4c2 Compare October 1, 2026 21:09
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because of no activity in the last 15 days. It will be closed in the next 5 days unless it is tagged "no stalebot" or other activity occurs.

@github-actions github-actions Bot added the stale This issue or PR has become stale label Oct 17, 2026
@tryambak2019
tryambak2019 force-pushed the fix/2689-python-startup-consolidation branch from c4af4c2 to 4761aca Compare October 19, 2026 14:40
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
Signed-off-by: tryambak2019 <tryambak_recdgp@yahoo.com>
@tryambak2019
tryambak2019 force-pushed the fix/2689-python-startup-consolidation branch from 4761aca to bd2a66b Compare October 19, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working stale This issue or PR has become stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit Python packages and samples after API v2 cutover

1 participant