Repository navigation
fix(substrate): limit Substrate views to watched namespaces - #3248
Open
danielle-mustillo wants to merge 2 commits into
Open
danielle-mustillo wants to merge 2 commits into
danielle-mustillo wants to merge 2 commits into
Conversation
danielle-mustillo
marked this pull request as ready for review
October 16, 2026 21:00
danielle-mustillo
force-pushed
the
danielle-mustillo/tenantScope
branch
from
October 16, 2026 21:02
cce5f8f to
4c00c04
Compare
- fix(substrate): limit Substrate views to watched namespaces - docs(substrate): say empty atespace lists watched atespaces - test(substrate): page tokens must name only watched data - fix(substrate): page only through watched namespaces - fix(substrate): time out GetWorker and read worker pods uncached - refactor(substrate): simplify page tokens and tests Signed-off-by: Danielle Mustillo <danielle.mustillo@solo.io>
- refactor(substrate): read workers through ate-api only - test(substrate): drop pod checks from the pass-through test - refactor(substrate): one worker walk for both scopes - test(substrate): drop duplicate worker tests - refactor(substrate): cap only actor tokens and drop duplicate tests - docs(ui): describe Substrate paging for watched namespaces - test(substrate): trim paging tests to unique branches Signed-off-by: Danielle Mustillo <danielle.mustillo@solo.io>
danielle-mustillo
force-pushed
the
danielle-mustillo/tenantScope
branch
from
October 16, 2026 21:10
4c00c04 to
7990b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
A kagent API user on a controller that watched some namespaces could read the Substrate data of other namespaces:
Resolution
The controller now returns only the Substrate data of its watched namespaces:
PermissionDenied.A controller that watches all namespaces works as before.
User Experience
A kagent API user on a controller that watches
ns-acan now share one Substrate with other teams and read only thens-aactors, templates and workers.Changes
ns-ans-bns-bdataPermissionDeniedns-adata onlyns-aworkers returned, in worker name orderns-browns-adataUpgrade note: an actor page token from a controller before this change, or a bad token, gets
InvalidArgument. Reload the UI page, or send the API request without the token.Limits
ListWorkers, one list call for a set of atespaces, and per-row checks or authz enforcement in ate-api.