Repository navigation
Retire stale version-conref TODO comments - #612
Closed
Rachael-Graham wants to merge 1 commit into
Closed
Rachael-Graham wants to merge 1 commit into
Rachael-Graham wants to merge 1 commit into
Conversation
The 0.x comment asked for a manual update whenever KIND_IMAGE_VERSION changes and named a path that no longer exists. update-ref-docs.yaml now writes max-kube from each release tag for both lines, so the manual step is gone. The 1.x comment described a nightly update-version-conrefs job and called kagent.md hand-maintained. The job has no schedule (a docs release triggers it) and it writes kagent.md from the tag too. Rewritten to list the conrefs the workflow actually writes, keeping the instruction to fix values in the workflow rather than in the conref. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Rachael Graham <rachael.graham@solo.io>
Docs preview
Both are uploaded Worker versions and serve no production traffic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two maintainer comments on the version pages describe how
update-ref-docs.yamlworked before it moved to release-tag runs.The 0.x Version Support page asked for a manual update whenever
KIND_IMAGE_VERSIONchanges and pointed at a path that no longer exists. The workflow now writesmax-kubefrom each release tag for both lines, so this PR deletes the comment.The 1.x Versions page described a nightly
update-version-conrefsjob and calledkagent.mdhand-maintained. The job has no schedule, since a docs release triggers it, and it writeskagent.mdfrom the tag. The comment now lists the conrefs the workflow actually writes and keeps the instruction to fix values in the workflow.Worth a close look: the conref list in the 1.x comment, checked against the
VERSIONS_DIRwrites inupdate-ref-docs.yamlon main.Comment-only change; nothing renders differently.
Please confirm the list matches the workflow and merge.
🤖 Generated with Claude Code