Repository navigation
fix(manual): say that Chrome capture starts with a fresh profile #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
namanarora00
wants to merge
1
commit into
kalil0321:main
from
namanarora00:fix/manual-chrome-profile-message
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| """Manual capture in real Chrome uses a fresh profile, not the user's own. | ||
|
|
||
| The user's Chrome profile directory is only checked to see that Chrome is installed. | ||
| Nothing is copied from it, so the capture starts signed out and the message must say so. | ||
| """ | ||
|
|
||
| from unittest.mock import MagicMock, patch | ||
|
|
||
| import pytest | ||
|
|
||
| pytest.importorskip("playwright") # ships in the [manual] extra only | ||
|
|
||
| from reverse_api.browser import ManualBrowser # noqa: E402 | ||
|
|
||
|
|
||
| def test_real_chrome_launches_with_a_fresh_profile_and_says_so(tmp_path): | ||
| user_profile = tmp_path / "Chrome" | ||
| user_profile.mkdir() | ||
| browser = ManualBrowser(run_id="testrun", prompt="grab jobs", output_dir=str(tmp_path / "runs")) | ||
| browser._playwright = MagicMock() | ||
| browser._playwright.chromium.launch_persistent_context.return_value.pages = [] | ||
|
|
||
| with ( | ||
| patch("reverse_api.browser.get_chrome_profile_dir", return_value=user_profile), | ||
| patch("reverse_api.browser.console") as console, | ||
| patch.object(browser, "close", return_value=browser.har_path), | ||
| ): | ||
| browser._start_with_real_chrome() | ||
|
|
||
| kwargs = browser._playwright.chromium.launch_persistent_context.call_args.kwargs | ||
| assert kwargs["channel"] == "chrome" | ||
| assert kwargs["user_data_dir"] != str(user_profile) | ||
| assert not any(user_profile.iterdir()) | ||
| printed = " ".join(str(call.args[0]) for call in console.print.call_args_list if call.args) | ||
| assert "fresh profile" in printed | ||
| assert "profile copy" not in printed | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test cannot detect copying the user's profile because
user_profileis empty. Copying its contents into the separate launch directory still passes every assertion; an in-memory mutation confirmed this. This is a non-blocking coverage gap: a future change could copy existing logins while the test passes and the message still promises a fresh profile.Add a synthetic cookie or settings file, assert that the source remains unchanged, and inspect
user_data_dirinside the mocked launch call to check that the file was not copied. Check there because the temporary directory is deleted before the method returns.Artifacts
Evidence from the check
Evidence from the check
Command output from the check
Command output from the check
Command output from the check
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!