Skip to content

fix: disable metrics for per-WorkspaceType multicluster managers #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2mind wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable metrics for per-WorkspaceType multicluster managers #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/controller/targetcontroller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import (
ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/manager"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
mcmanager "sigs.k8s.io/multicluster-runtime/pkg/manager"
)
Expand Down Expand Up @@ -266,6 +267,12 @@ func (r *Reconciler) createMulticlusterManager(wst *kcptenancyv1alpha1.Workspace

mgr, err := mcmanager.New(wstConfig, provider, manager.Options{
Scheme: scheme,

// Every WorkspaceType gets its own multicluster manager in this process, but
// controller-runtime's metrics server defaults to ":8080", so the second manager
// fails to come up with "listen tcp :8080: bind: address already in use" and its
// WorkspaceType is never initialized. Only the main manager needs to serve metrics.
Metrics: metricsserver.Options{BindAddress: "0"},
})
if err != nil {
return nil, fmt.Errorf("failed to create manager: %w", err)
Expand Down