Repository navigation
CLI: Update Go SDK to v0.145.0 - #316
Open
kernel-internal[bot] wants to merge 1 commit into
Open
kernel-internal[bot] wants to merge 1 commit into
kernel-internal[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.145.0.Coverage
CLI coverage update for Kernel Go SDK v0.145.0
Summary
github.com/kernel/kernel-go-sdkfromv0.144.0tov0.145.0ingo.modandgo.sum.state.credential_typeto the CLI's display-safe vault output.cardorlink_pay_token.link_pay_tokenfills without field bindings, whilecardfills with the advertised card fields.credential_typeis treated ascard, matching the API contract.kernel proxy-ips list --per-pagenow accepts up to 999 items while reserving one API result for the required pagination lookahead.No new commands or flags were needed.
SDK and CLI coverage review
A complete enumeration found:
api.md.x-cli-skip: true.The v0.144.0 to v0.145.0 SDK diff adds no methods and no request parameter fields. The only new SDK field is the response-only Link
credential_type, which is now surfaced by vault item output.Help text synchronized with the API specification
Updated CLI text and behavior to follow:
LinkCardState.credential_type(cardorlink_pay_token)card.state.credential_typerather than choose a delivery type.DELETE /org/api_keys/{id}POST /org/api_keys/{id}/rotate--expire-in-daysusage now explain the immediate-expiry cleanup behavior.GET /proxy_ipsquery parameterlimit--per-pagemaximum is 999.Intentional exclusions
x-cli-skip: true.credential_typeis response state, not user input, so it is displayed rather than exposed as a flag.Validation
go test ./...— passed.go build ./...— passed.go vet ./...— passed../cmd/kernel— passed.state.credential_typeguidance, and--per-page 1-999usage.--per-page 1000fails before an API request with the expected range error.--per-page 999reached the service, but the test organization does not have reserved ISP IPs enabled, so a successful reserved-IP response could not be verified.Validation
Note
Low Risk
Mostly documentation, display filtering, and client-side pagination validation on an SDK bump; no new destructive defaults beyond clearer confirmations for API key operations.
Overview
Bumps
github.com/kernel/kernel-go-sdkto v0.145.0 and aligns the CLI with the new API semantics.Link vault items now surface
state.credential_type(cardorlink_pay_token) in filtered JSON and human item output, with fill guidance that matches each type and treats missingcredential_typeon ready items like card. Shared Link checkout help documents that Kernel picks the delivery type at authorize time.API key delete and rotate help, flag usage, and confirmation prompts now warn that immediate expiry or deletion asynchronously ends browser sessions tied to the key and discards unsaved profile changes, and clarify grace-period vs immediate rotation.
Reserved ISP proxy listing raises the effective
--per-pageceiling to 999 (one slot reserved for pagination lookahead against the API’s 1000-item limit) and rejects larger values before calling the API.Unit tests lock in the new help strings, pagination limits, and Link credential-type output.
Reviewed by Cursor Bugbot for commit b61594f. Bugbot is set up for automated code reviews on this repo. Configure here.