Repository navigation
Use mirrored private base images in source builds - #544
Closed
sjmiller609 wants to merge 1 commit into
Closed
sjmiller609 wants to merge 1 commit into
sjmiller609 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing because the private base-image migration is no longer required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing host-side registry mirror for non-Docker-Hub base images, so source builds can consume authenticated bases without registry passwords in build guests.
The source registry still uses Docker's existing default keychain, including credential helpers. No new API/SDK fields or builder-image rebuild is required. Configure the host's source-registry authentication before switching consumers.
Validation
go test -short -p 4 ./lib/builds ./lib/imagesand vet pass. Repeated race tests pass for the new cases. An authenticated HTTP-registry test verifies index preservation, digest rewriting, the actual archive passed to volume import, unchanged stored input, and absence of source credentials from guest config. Disabling archive rewriting makes the regression test fail.No live hypervisor/source-build deployment was performed.