Repository navigation
Conversation
4 tasks
Contributor
Author
|
Picked tnsardesai to review these related PRs (kernel/security-workflows#36, kernel/kernel#5359, #550, kernel/infra#2088, kernel/kernel-images-private#584): touched the changed code in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets the PR Risk check run on federated model credentials instead of stored API keys.
kernel/security-workflows#36 changes the reusable
pr-risk.ymlso its classify job requestsid-token: write. It exchanges the job's GitHub OIDC token for short-lived Anthropic/OpenAI credentials. A reusable workflow job can't request more permissions than its caller grants, so this caller grantsid-token: write.Merge this before kernel/security-workflows#36. It changes nothing with the current
pr-risk.yml, which ignores the extra permission. If #36 merges first, PR Risk fails to start here until this lands.The
ANTHROPIC_API_KEY/OPENAI_API_KEYsecrets are still passed. #36 ignores them, and they'll be removed in a follow-up once every caller has switched.Testing
kernel/security-workflows#36 was tested end to end: a caller granting
id-token: writecalled the newpr-risk.ymlon a throwaway PR with no API keys passed, and the classifier ran and posted its comment.