Repository navigation
Read Docker Hub CI credentials from SSM - #507
Open
sjmiller609 wants to merge 4 commits into
Open
sjmiller609 wants to merge 4 commits into
sjmiller609 wants to merge 4 commits into
Conversation
sjmiller609
marked this pull request as ready for review
November 9, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisites
The SSM read permissions must deploy and the production SecureString
/kernel/dockerhub/credentialsmust be populated first. Other consumers pin the shared action commit from this PR.Validation
Live SSM reads, image builds, and e2e tests were not run locally.
Note
Medium Risk
Changes how registry credentials are sourced and which CI events can reach AWS/Docker Hub; misconfigured SSM or workflow guards could block builds or widen credential exposure.
Overview
Adds a shared composite action dockerhub-credentials that loads username/password from SSM (
/kernel/dockerhub/credentials), masks them in logs, validates SecureString JSON shape, and optionally assumes an IAM role without clobbering the caller’s existing AWS session env.Chromium image and server e2e workflows now log into Docker Hub via that action (using
github-actions-kernel-images) instead ofvars.DOCKERHUB_*/secrets.DOCKERHUB_TOKEN, withid-token: writewhere OIDC is needed. Credential-bearing image builds are gated to trusted non–pull_request runs onkernel/kernel-images(replacing the fork-PR skip based on head repo). server-test also runs on push to all branches, not onlymain.Reviewed by Cursor Bugbot for commit 230a381. Bugbot is set up for automated code reviews on this repo. Configure here.