Skip to content

Honor the latest WebRTC policy across flag merges - #509

Closed
JonnyShuali wants to merge 1 commit into
mainfrom
hypeship/webrtc-policy-merge
Closed

JonnyShuali wants to merge 1 commit into
mainfrom
hypeship/webrtc-policy-merge

Conversation

@JonnyShuali

@JonnyShuali JonnyShuali commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Returning a WebRTC policy to an earlier/base value could leave an intervening policy active: exact-token deduplication retained the first occurrence. Treat --webrtc-ip-handling-policy as a singleton whose last value wins during both runtime-file merging and launcher merging. Other flag merge behavior is unchanged.

Validation: the new two-stage merge regression failed before the fix and passes for native, suppressed and emulated transitions. The complete server short unit suite passed, excluding Docker e2e tests. No browser-engine binary or image was rebuilt.

Publish this launcher fix in any image approved for explicit WebRTC policy rollout. Verify rollback to a value already present in base flags before approving that image's digest.


Note

Low Risk
Scoped change to flag-merge deduplication for one Chromium switch, with unit test coverage; launcher behavior for other flags is unchanged.

Overview
Chromium flag merging now treats --webrtc-ip-handling-policy as a singleton where the last value wins (matching Chromium), instead of keeping the first token during exact-string dedupe. That fixes rollbacks and runtime updates where an older policy could stick when merging base env flags with persisted runtime overlays.

A regression test exercises two-stage merges (MergeFlags then MergeFlagsWithRuntimeTokens) across policy transitions so the final launcher flags always carry a single, latest policy value.

Reviewed by Cursor Bugbot for commit 35ced7c. Bugbot is set up for automated code reviews on this repo. Configure here.

@JonnyShuali

Copy link
Copy Markdown
Contributor Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 35ced7c. Configure here.

@JonnyShuali JonnyShuali closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant