Repository navigation
Honor the latest WebRTC policy across flag merges - #509
Closed
JonnyShuali wants to merge 1 commit into
Closed
JonnyShuali wants to merge 1 commit into
JonnyShuali wants to merge 1 commit into
Conversation
Contributor
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 35ced7c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning a WebRTC policy to an earlier/base value could leave an intervening policy active: exact-token deduplication retained the first occurrence. Treat
--webrtc-ip-handling-policyas a singleton whose last value wins during both runtime-file merging and launcher merging. Other flag merge behavior is unchanged.Validation: the new two-stage merge regression failed before the fix and passes for native, suppressed and emulated transitions. The complete server short unit suite passed, excluding Docker e2e tests. No browser-engine binary or image was rebuilt.
Publish this launcher fix in any image approved for explicit WebRTC policy rollout. Verify rollback to a value already present in base flags before approving that image's digest.
Note
Low Risk
Scoped change to flag-merge deduplication for one Chromium switch, with unit test coverage; launcher behavior for other flags is unchanged.
Overview
Chromium flag merging now treats
--webrtc-ip-handling-policyas a singleton where the last value wins (matching Chromium), instead of keeping the first token during exact-string dedupe. That fixes rollbacks and runtime updates where an older policy could stick when merging base env flags with persisted runtime overlays.A regression test exercises two-stage merges (
MergeFlagsthenMergeFlagsWithRuntimeTokens) across policy transitions so the final launcher flags always carry a single, latest policy value.Reviewed by Cursor Bugbot for commit 35ced7c. Bugbot is set up for automated code reviews on this repo. Configure here.