Repository navigation
Use federated model credentials instead of static LLM API keys - #510
Merged
Merged
Conversation
Contributor
Author
|
Picked ulziibay-kernel to review: touched the changed code in |
rgarcia
requested review from
JonnyShuali
and removed request for
ulziibay-kernel
November 9, 2026 21:36
Contributor
Author
|
Picked JonnyShuali to review: these caller changes only add |
JonnyShuali
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of removing the static
ANTHROPIC_API_KEY/OPENAI_API_KEYorg secrets from GitHub Actions. The reusable workflows inkernel/security-workflowsare moving to itsllm-credentialscomposite action (documented in that repo's README, "llm-credentials action"), which exchanges the job's GitHub OIDC token for short-lived Anthropic/OpenAI credentials via workload identity federation. Reusable workflows can only useid-token: writeif the caller grants it..github/workflows/semgrep.yml: addid-token: writeto the top-levelpermissions:(existing entries kept) so the called semgrep workflow can mint an OIDC token..github/workflows/vuln-remediation.yml: same, for the called vuln-remediation workflow.No other changes. Neither file in this repo references the API key secrets directly (they pass
secrets: inherit), andrg -n 'ANTHROPIC_API_KEY|OPENAI_API_KEY' .githubreturns nothing.Safe to merge now: the permission is unused until
kernel/security-workflowsswitches these reusable workflows to the action, which happens only after every caller has the permission.Testing
actionlint1.7.7 (sha256-verified release binary) withshellcheck0.10.0 on both changed workflows: no findings.