Repository navigation
chore(devtools-vite): remove dead @tanstack/devtools:config plugin block - #32
Merged
kharyaji00-tech merged 1 commit intoOct 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Removed the no-op
@tanstack/devtools:configsub-plugin fromdevtools-vite/src/plugin.tsand its corresponding row in the vite-plugin SKILL.md table. The plugin'sconfighook returnedundefinedon both branches (early-return for non-serve; only a commented-out block for serve), so it had no runtime effect on Vite.Context
The plugin was introduced in TanStack#200 to apply Solid.js dedupe-deps config and was reverted in TanStack#205 by wrapping the body in
/* ... */, leaving an emptyconfighook plus a 16-line commented-out block. It has been a no-op for over a year, the paralleldevtools-rspackplugin (1:1 Vite parity) omits this slot entirely, and no tests or other packages reference it. The SKILL.md "Reserved for future config modifications" note was auto-scaffolded by@tanstack/intentin TanStack#377 (post-dating the revert by ~5 months), not a maintainer reservation. Removing it follows the precedent set by the earlier removal of@tanstack/devtools:port-injection.History
✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Generated with: Detail: Dead Code
Dead Code PRs can be configured here.