Skip to content

chore(devtools-vite): remove dead @tanstack/devtools:config plugin block - #32

Merged
kharyaji00-tech merged 1 commit into
mainfrom
detail/dead-code/chore-devtools-vite-remove-dead-tanstack-devtools-e85e77
Oct 27, 2026
Merged

kharyaji00-tech merged 1 commit into
mainfrom
detail/dead-code/chore-devtools-vite-remove-dead-tanstack-devtools-e85e77

Conversation

@detail-app

@detail-app detail-app Bot commented Oct 27, 2026

Copy link
Copy Markdown

🎯 Changes

Removed the no-op @tanstack/devtools:config sub-plugin from devtools-vite/src/plugin.ts and its corresponding row in the vite-plugin SKILL.md table. The plugin's config hook returned undefined on both branches (early-return for non-serve; only a commented-out block for serve), so it had no runtime effect on Vite.

Context

The plugin was introduced in TanStack#200 to apply Solid.js dedupe-deps config and was reverted in TanStack#205 by wrapping the body in /* ... */, leaving an empty config hook plus a 16-line commented-out block. It has been a no-op for over a year, the parallel devtools-rspack plugin (1:1 Vite parity) omits this slot entirely, and no tests or other packages reference it. The SKILL.md "Reserved for future config modifications" note was auto-scaffolded by @tanstack/intent in TanStack#377 (post-dating the revert by ~5 months), not a maintainer reservation. Removing it follows the precedent set by the earlier removal of @tanstack/devtools:port-injection.

History

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Generated with: Detail: Dead Code


Dead Code PRs can be configured here.

@kharyaji00-tech
kharyaji00-tech merged commit d7b3f29 into main Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant