Skip to content

fix: remove io module when enabling sandbox mode #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
killme2008 merged 1 commit into from
Jul 19, 2026
+17 −11
Merged

fix: remove io module when enabling sandbox mode #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/main/java/com/googlecode/aviator/AviatorEvaluatorInstance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,7 @@ public void enableSandboxMode() {
setOption(Options.ALLOWED_CLASS_SET, Collections.emptySet());
setOption(Options.ASSIGNABLE_ALLOWED_CLASS_SET, Collections.emptySet());
setOption(Options.EVAL_TIMEOUT_MS, 1000L);
this.removeModule(this.getModuleName(IoModule.class));
}

/**
Expand All @@ -489,17 +490,7 @@ public void enableSandboxMode() {
*/
public Env addModule(final Class<?> moduleClazz)
throws NoSuchMethodException, IllegalAccessException {
String namespace = moduleClazz.getSimpleName();

Import importAnt = moduleClazz.getAnnotation(Import.class);

if (importAnt != null) {
namespace = importAnt.ns();
if (namespace == null || namespace.isEmpty()
|| !ExpressionParser.isJavaIdentifier(namespace)) {
throw new IllegalArgumentException("Invalid namespace in Import annotation: " + namespace);
}
}
String namespace = getModuleName(moduleClazz);

Env exports = null;
synchronized (namespace.intern()) {
Expand All @@ -513,6 +504,21 @@ public Env addModule(final Class<?> moduleClazz)
}
}

private String getModuleName(final Class<?> moduleClazz) {
String namespace = moduleClazz.getSimpleName();

Import importAnt = moduleClazz.getAnnotation(Import.class);

if (importAnt != null) {
namespace = importAnt.ns();
if (namespace == null || namespace.isEmpty()
|| !ExpressionParser.isJavaIdentifier(namespace)) {
throw new IllegalArgumentException("Invalid namespace in Import annotation: " + namespace);
}
}
return namespace;
}

/**
* Remove a module by namespace name.
*
Expand Down
Loading