Skip to content

Fix build, add tests/CI, persist settings, consolidate mode metadata - #1

Merged
knarayanareddy merged 1 commit into
mainfrom
arena/fbdf5bf7-appbuilder
Nov 3, 2026
Merged

Fix build, add tests/CI, persist settings, consolidate mode metadata#1
knarayanareddy merged 1 commit into
mainfrom
arena/fbdf5bf7-appbuilder

Conversation

@knarayanareddy

@knarayanareddy knarayanareddy commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Highest-value improvements for the ProCam Ultra app:

Bugs fixed

  • Build blocker: was empty/invalid JSON, crashing in the Tailwind resolver. Now valid . Build passes.
  • GalleryView buttons non-functional: Delete/Share/Download/Trash had no handlers; wired them up. RAW stat now computed instead of hardcoded .
  • EV scale misleading: indicator hardcoded to center; now reflects .
  • Dead code: removed unused in (failing ).
  • Weak typing: was , now .

Reliability / DX

  • Settings persistence: camera settings, presets, and mode now persist to and survive reloads. Preset IDs use ; stop-list navigation guards against preset values not in the canonical lists.
  • Single source of truth: mode labels/icons/colors/gradients consolidated into (was duplicated across 5 files; Gallery filter omitted 4 modes).
  • Test suite: Vitest + React Testing Library, 12 passing tests.
  • CI: GitHub Actions workflow (type-check → lint → test → build) on push/PR.
  • DX: added , ESLint flat config, Prettier, expanded README.

All checks green: , , , (12/12).

@knarayanareddy @arena-agent
Fix build, add tests/CI, persist settings, consolidate mode metadata
6a41661 
- Fix empty src/package.json that crashed vite build (Tailwind resolver JSON.parse)
- Wire up GalleryView Delete/Share/Download/Trash handlers; compute RAW count stat
- Fix EV-scale indicator hardcoded to center; reflect settings.ev
- Remove dead currentStop variable in ZoomSlider (strict TS noUnusedLocals)
- Type ProControlBar mode as ShootingMode instead of string
- Persist settings/presets/mode to localStorage; UUID preset IDs; guard stop-list navigation
- Consolidate mode metadata into single source of truth (src/lib/modes.ts)
- Add Vitest + React Testing Library suite (12 tests) and GitHub Actions CI
- Add .gitignore, ESLint flat config, Prettier, and expanded README

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T08:36:05.520124Z
We couldn’t complete this review. Comment @codex review to try again.		 6a41661 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2744a833-3a7b-41f7-a22d-79d532352a65
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@knarayanareddy
knarayanareddy merged commit 4509949 into main Nov 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@knarayanareddy