Return an error instead of panicking on a valueless mount option

[arpitjain099]

Description

kn service create foo --image ... --mount /mydir=ed:ed1:readOnly panics with index out of range [1] with length 1. parseMountOptions splits each option on = and reads pair[1] for the readonly case without checking that the split produced two elements, so leaving off the value crashes the CLI instead of printing a usage error. The flag help documents readOnly=true | false, so a bare readOnly is a plausible typo.

While in there I removed a leftover in getMountInfo: it splits the option string and runs a switch whose only case is empty, then ignores the result. It has no effect.

Changes

• Reject a readonly mount option with no value and return an error naming the option
• Drop the no-op switch in getMountInfo
• Test covering readonly=true, readonly=false, readonly=, bare readonly and an unknown option

Reference

Fixes #

Release Note

Using --mount with a readOnly option and no value now returns an error instead of panicking.

[knative-prow]

Welcome @arpitjain099! It looks like this is your first PR to knative/client 🎉

[knative-prow]

Hi @arpitjain099. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arpitjain099
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/ok-to-test

[knative-prow]

@arpitjain099: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
build-tests_client_main	61cb684	link	true	/test build-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (63f8b66) to head (61cb684).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
+ Coverage   71.88%   71.90%   +0.01%     
==========================================
  Files         233      233              
  Lines       13535    13534       -1     
==========================================
+ Hits         9730     9731       +1     
+ Misses       2999     2997       -2     
  Partials      806      806              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.