Skip to content

fix(migrations): preserve legacy deployer intent after undeploy - #4076

Open
Elvand-Lie wants to merge 2 commits into
knative:mainfrom
Elvand-Lie:test/fingerprint-comment-mtime
Open

Elvand-Lie wants to merge 2 commits into
knative:mainfrom
Elvand-Lie:test/fingerprint-comment-mtime

Conversation

@Elvand-Lie

@Elvand-Lie Elvand-Lie commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4054.

Legacy func.yaml files stored the selected deployer only under deploy.deployer. func delete clears that deployment state, so the next deploy falls back to the configured default.

Recover missing top-level deployer intent when migrating files whose specVersion is below 0.39.0. This preserves the selected deployer across delete and redeploy while preserving explicit intent and observed state.

Testing: regression tests cover legacy YAML loading and CLI delete/redeploy for raw, KEDA and Knative, including global defaults and flag/environment overrides. The recovery cases fail on main and pass with this fix; the control cases pass on both. Full Linux make test and make check passed. This PR also makes an existing fingerprint test explicitly advance the file timestamp so rapid writes cannot cause a spurious failure.

Files whose specVersion is already 0.39.0 or later with only observed deployer state are outside this migration's scope. Windows/macOS and cluster tests were not run locally.

/kind bug

Legacy functions retain their selected deployer after delete and redeploy instead of falling back to the configured default.
N/A

Fingerprint hashes file paths and modification timestamps. Rapid
writes can retain the same mtime, making the comment-pattern test
fail even when the file is correctly tracked.

Capture the original mtime and explicitly advance it by two seconds
after rewriting notes.txt. Keep both inclusion and modification
assertions and avoid sleeps or production fingerprint changes.

Assisted-by: OpenAI Codex and Claude Code
Signed-off-by: Elvand Lie Nababan <elvandlie@gmail.com>
@knative-prow knative-prow Bot added the kind/cleanup Cleanup label Oct 11, 2026
@knative-prow

knative-prow Bot commented Oct 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elvand-Lie
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Oct 11, 2026
@knative-prow

knative-prow Bot commented Oct 11, 2026

Copy link
Copy Markdown

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Legacy func.yaml files stored the chosen deployer only in observed
state. Deleting clears that state, causing redeploy to fall back to
the configured default. Recover missing top-level intent during
migration while preserving explicit intent and observed state.

Exercise real YAML loading and CLI delete, reload and redeploy for
legacy 0.36.0 and 0.38.0 files, all deployers, global defaults, and
flag and environment overrides. Keep plain redeploy as a control.

Fixes knative#4054

Assisted-by: OpenAI Codex and Claude Code
Signed-off-by: Elvand Lie Nababan <elvandlie@gmail.com>
@Elvand-Lie Elvand-Lie changed the title test(functions): make funcignore comment test deterministic fix(migrations): preserve legacy deployer intent after undeploy Oct 11, 2026
@knative-prow knative-prow Bot added size/L 🤖 PR changes 100-499 lines, ignoring generated files. and removed size/XS 🤖 PR changes 0-9 lines, ignoring generated files. labels Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Cleanup needs-ok-to-test 🤖 Needs an org member to approve testing size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy deploy.deployer-only functions lose deployer intent on func delete then func deploy

1 participant