Repository navigation
feat: add reusable Kind cluster action - #1087
Soundcreates wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Kubeconfig handling can produce invalid relative paths, and the documentation uses mutable action references.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a reusable composite action for provisioning Kind clusters in CI and documents its usage.
Changes:
- Adds configurable Kind cluster creation with kubeconfig export.
- Documents inputs and example workflow usage.
File summaries
| File | Description |
|---|---|
.github/actions/create-cluster/action.yml |
Defines cluster provisioning and kubeconfig handling. |
README.md |
Documents the reusable action and usage example. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I'll address these changes and update them shortly |
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
f47d430 to
3a58c2f
Compare
|
I checked the three review notes against the current head. The action resolves relative |
tariq-hasan
left a comment
There was a problem hiding this comment.
Thank you for driving the effort @Soundcreates! As discussed in #1068 (comment) please base the implementation on the KFP action - https://github.com/kubeflow/pipelines/blob/master/.github/actions/create-cluster/action.yml. Please also make sure to bring in the helpers in the action as well.
@jaiakash I think best to move GPU support into a follow-up PR so we can keep this one focused on runner prep and provisioning. What do you think? Opt-in add-ons (such as GPU support), component install (#1075), test execution (#1088), diagnostics and teardown can come in as follow-up PRs.
@Soundcreates To make sure we test this action in CI please also add a separate workflow in this repo that runs the action across the supported K8s versions and verifies the cluster is reachable (e.g. kubectl get nodes).
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
cae69ec to
bef60dc
Compare
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
tariq-hasan
left a comment
There was a problem hiding this comment.
Hi @Soundcreates! Thank you for the effort. I have added a few comments.
Signed-off-by: Shantanav Mukherjee <shantanav7@gmail.com>
Fixes #1068
Summary
KUBECONFIGvalues before Kind starts and expose the resulting absolute path.Validation
KUBECONFIGhandling.