Skip to content

bump yargs 17.7.3 to fix release release workflow and c8 node26 compat#2910

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-client:mainfrom
davidgamero:david/release-c8-compat-fix-node26
Jun 24, 2026
Merged

bump yargs 17.7.3 to fix release release workflow and c8 node26 compat#2910
kubernetes-prow[bot] merged 2 commits into
kubernetes-client:mainfrom
davidgamero:david/release-c8-compat-fix-node26

Conversation

@davidgamero

@davidgamero davidgamero commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

release 17.7.3 of yargs fixes #2848

remove test-no-coverage script as new yargs patch version fixes previous issue with extensions

c8 coverage works on node26 again which will unblock release workflow that's failing on c8

yargs/yargs#2514
https://github.com/yargs/yargs/releases/tag/v17.7.3

@kubernetes-prow kubernetes-prow Bot requested review from cjihrig and mstruebing June 24, 2026 16:26
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2026
@davidgamero davidgamero changed the title release c8 node26 fix bump yargs 17.7.3 release c8 node26 fix Jun 24, 2026
@davidgamero davidgamero changed the title bump yargs 17.7.3 release c8 node26 fix bump yargs 17.7.3 to fix release release workflow and c8 node26 compat Jun 24, 2026

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cjihrig,davidgamero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot merged commit cfb2fb2 into kubernetes-client:main Jun 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants