Skip to content

kamatera cloudprovider refactor, fixes, improvements#9740

Open
OriHoch wants to merge 1 commit into
kubernetes:masterfrom
Kamatera:master
Open

kamatera cloudprovider refactor, fixes, improvements#9740
OriHoch wants to merge 1 commit into
kubernetes:masterfrom
Kamatera:master

Conversation

@OriHoch

@OriHoch OriHoch commented Jun 4, 2026

Copy link
Copy Markdown
Member

this PR replaces #9123 which had some problems with rebasing and was accidentaly closed

What type of PR is this?

/kind bug
/kind cleanup
/kind feature

What this PR does / why we need it:

After running the Kamatera cloudprovider for some customers a few months this PR does a lot of fixes and improvements from feedback we got.

Special notes for your reviewer:

Changes were well tested using our internal end-to-end testing suite on Kamatera infrastructure. Also, many unit tests were added.

Does this PR introduce a user-facing change?

Kamatera cloudprovider: added options for node scale up/down by turning servers on/off rather then deleting them. Many stability and speed-up improvements.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 4, 2026
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component labels Jun 4, 2026
@k8s-ci-robot k8s-ci-robot requested a review from BigDarkClown June 4, 2026 15:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jun 4, 2026
@k8s-ci-robot

k8s-ci-robot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Hi @OriHoch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 4, 2026
@OriHoch OriHoch mentioned this pull request Jun 4, 2026
Closed
@OriHoch

OriHoch commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm just waiting for our integration tests on kamatera servers to complete to ensure this rebased PR is ready, it takes around 1.5 hours
verified, ready for merge

@OriHoch OriHoch marked this pull request as ready for review June 4, 2026 21:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2026
@OriHoch

OriHoch commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@OriHoch: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@OriHoch

OriHoch commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot

k8s-ci-robot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@OriHoch: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@OriHoch

OriHoch commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2026
@OriHoch

OriHoch commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2026
@OriHoch

OriHoch commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

k8s-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OriHoch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OriHoch @k8s-ci-robot