ca(docs): document how pdb eviction works#9741
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LucasAndFlores The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @LucasAndFlores! |
|
Hi @LucasAndFlores. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
869f8aa to
bfa927e
Compare
elmiko
left a comment
There was a problem hiding this comment.
content looks good to me, just a question about the separator.
| | `vmodule` | comma-separated list of pattern=N settings for file-filtered logging (only works for text log format) | | | ||
| | `write-status-configmap` | Should CA write status information to a configmap | true | | ||
|
|
||
| **************** |
There was a problem hiding this comment.
do we need this separator? (eg is it part of the table)
There was a problem hiding this comment.
I realized that I placed this in the wrong place, sorry. But I noticed in the end of all sections we have it this separators, which is an horizontal rule. If you want, I can remove it
What type of PR is this?
I added this section specifically just to document the behavior if we are scaling down the nodes and we have a pod match a PDB label selector
/kind documentation
What this PR does / why we need it:
I intend to improve/document the behavior of scaling down nodes in case we have pods matching PDB labels. I went deep into this until I understand some parts. If you think is relevant, I can try to explain how the disruptionAllowed is calculated.
Which issue(s) this PR fixes:
No fix, just improve faq.md
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE