Skip to content

Add CRD-level label selector validation to CapacityQuota#9780

Open
norbertcyran wants to merge 1 commit into
kubernetes:masterfrom
norbertcyran:cq-selector-validation
Open

Add CRD-level label selector validation to CapacityQuota#9780
norbertcyran wants to merge 1 commit into
kubernetes:masterfrom
norbertcyran:cq-selector-validation

Conversation

@norbertcyran

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added CRD-level validation for CapacityQuota selector. Adding validation on CRD required mirroring the LabelSelector struct from apimachinery. Otherwise, CEL rules would have too high cost and CRD would not apply.

Which issue(s) this PR fixes:

Part of #8703

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added CRD validation to CapacityQuota selector

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 9, 2026
@norbertcyran

Copy link
Copy Markdown
Contributor Author

/assign x13n

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jun 9, 2026
@k8s-ci-robot k8s-ci-robot requested review from mtrqq and x13n June 9, 2026 13:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. label Jun 9, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2026
@norbertcyran norbertcyran force-pushed the cq-selector-validation branch from eb0d78b to 6e29df2 Compare June 9, 2026 14:31
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: norbertcyran
Once this PR has been reviewed and has the lgtm label, please ask for approval from x13n. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Adding validation on CRD required mirroring the LabelSelector struct
from apimachinery. Otherwise, CEL rules would have too high cost and CRD
 would not apply.
@norbertcyran norbertcyran force-pushed the cq-selector-validation branch from 6e29df2 to 91693c6 Compare June 10, 2026 09:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants