Add CRD-level label selector validation to CapacityQuota#9780
Add CRD-level label selector validation to CapacityQuota#9780norbertcyran wants to merge 1 commit into
Conversation
|
/assign x13n |
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
eb0d78b to
6e29df2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: norbertcyran The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Adding validation on CRD required mirroring the LabelSelector struct from apimachinery. Otherwise, CEL rules would have too high cost and CRD would not apply.
6e29df2 to
91693c6
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added CRD-level validation for CapacityQuota selector. Adding validation on CRD required mirroring the LabelSelector struct from apimachinery. Otherwise, CEL rules would have too high cost and CRD would not apply.
Which issue(s) this PR fixes:
Part of #8703
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: