Skip to content

RFC: integrate extender-managed resources#9786

Open
fishman wants to merge 1 commit into
kubernetes:masterfrom
fishman:master
Open

RFC: integrate extender-managed resources#9786
fishman wants to merge 1 commit into
kubernetes:masterfrom
fishman:master

Conversation

@fishman

@fishman fishman commented Jun 10, 2026

Copy link
Copy Markdown
  • Register extender-managed resources as custom GPU vendor resource names at startup
  • Add Extenders field to framework.Handle and create HTTP extenders from scheduler config
  • Pass extenders to SchedulerPluginRunner and filter nodes via runExtenderFilters
  • Refactor RunFiltersUntilPassingNode to collect all passing nodes for extender post-filtering

What type of PR is this?

/kind feature

What this PR does / why we need it:

Extenders (e.g., for vendor GPU resources) must be correctly wired into the scheduler to avoid scheduling pods onto nodes that cannot satisfy extender-managed resources. Fixes Azure/AKS#5301

Which issue(s) this PR fixes:

Addresses Azure/AKS#5301 but does not sufficiently fix it yet.

Special notes for your reviewer:

It's not properly tested yet, but in the HAMi scenario it wouldn't work correctly, because HAMi's virtualized resources may not map properly to the information cluster autoscaler uses. So either the extender needs an interface change, or the config format needs additional work. But since different accelerators may use different proportions i'm not sure if the standardization of those resource proportions should happen on the cluster autoscaler side.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Not a KEP yet, just looking for feedback

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 10, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 10, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: fishman / name: Reza Jelveh (82c50e4)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @fishman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2026
@k8s-ci-robot k8s-ci-robot requested review from elmiko and x13n June 10, 2026 09:15
@k8s-ci-robot k8s-ci-robot added the area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component label Jun 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fishman
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 10, 2026

@elmiko elmiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a question about the makefile change.

/ok-to-test

Comment thread cluster-autoscaler/Makefile Outdated
@@ -1,4 +1,4 @@
ALL_ARCH = amd64 arm64 s390x
ALL_ARCH = amd64 # arm64 s390x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we are disabling the other architectures?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slipped through, I was just testing, but I revised the commit locally, and I guess I forgot to push it.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2026
- Register extender-managed resources as custom GPU vendor resource names at startup
- Add `Extenders` field to `framework.Handle` and create HTTP extenders from scheduler config
- Pass extenders to `SchedulerPluginRunner` and filter nodes via `runExtenderFilters`
- Refactor `RunFiltersUntilPassingNode` to collect all passing nodes for extender post-filtering
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@fishman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-gci-gce-ca-test 303672c link false /test pull-autoscaling-e2e-gci-gce-ca-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] HAMi Scheduler and Cluster Autoscaler Integration Support in AKS

3 participants