fix: AWS HasInstance should ignore unrecognized provider IDs#9801
fix: AWS HasInstance should ignore unrecognized provider IDs#9801Arthurhussey wants to merge 1 commit into
Conversation
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @Arthurhussey! |
|
Hi @Arthurhussey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Arthurhussey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The AWSCloudProvider only supports aws://zone/name ProviderIDs. kubernetes#8047 fixed NodeGroupForNode to ignore ProviderIDs it does not recognize (e.g. eks-hybrid:// for EKS Hybrid Nodes, or SageMaker HyperPod nodes joined to an EKS cluster), but HasInstance still propagates the parse error, which surfaces as errors in the autoscaler loop when such nodes are present. Apply the same handling: log at V(6) and report the node as not present. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5940b9a to
4e7ce42
Compare
What type of PR is this?
/kind bug
/area provider/aws
What this PR does / why we need it:
The AWSCloudProvider only supports
aws://zone/nameProviderIDs. #8047 fixedNodeGroupForNodeto ignore ProviderIDs it does not recognize (e.g.eks-hybrid://...for EKS Hybrid Nodes, or SageMaker HyperPod nodes joined to an EKS cluster), butHasInstancestill propagates the parse error, which surfaces as errors in the autoscaler loop when such nodes are present in the cluster.This applies the same handling to
HasInstance: log at V(6) and report the node as not present, matching the existing pattern inNodeGroupForNode.Which issue(s) this PR fixes:
None filed; same class of issue as #8047.
Special notes for your reviewer:
Adds a test case to
TestHasInstancemirroring the one added in #8047.🤖 Generated with Claude Code