Cache compiled regular expressions in the log buffer#1322
Conversation
This change keeps each compiled regular expression in a cache in the log buffer. The cache size is not more than the number of patterns given to Match. This change removes the TODO in log_buffer.go.
|
Hi @DigitalVeer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DigitalVeer, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-npd-build |
Summary
The log buffer keeps each compiled regular expression in a cache.
The cache size is not more than the number of patterns given to
Match.This PR removes the TODO in
log_buffer.go.Benchmark
One
Matchcall with a default kernel monitor pattern: