Skip to content

Fixed an issue where Zed extension read settings from lsp.path-server.settings rather than lsp.path-server-lsp.settings #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunlinglio merged 1 commit into from
Oct 2, 2026
Merged

Fixed an issue where Zed extension read settings from lsp.path-server.settings rather than lsp.path-server-lsp.settings #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the Path Server will be documented in this file.

## [Unreleased]
### Fixed
- **Zed**: Fixed an issue where Zed extension read settings from `lsp.path-server.settings` rather than `lsp.path-server-lsp.settings`. ([#55](https://github.com/kunlinglio/path-server/issues/55))

## [1.4.2] - 2026-09-14
Path Server is now published to Open VSX! You can now view it at https://open-vsx.org/extension/LKL/path-server
### Fixed
Expand Down
13 changes: 8 additions & 5 deletions extensions/zed/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ impl PathServerExtension {
return Err("No asset found with name.".to_string());
};

// 3. create dir: path-server-vx.x.x
// 4. create dir: path-server-vx.x.x
let Ok(_) = std::fs::create_dir_all(EXECUTABLE_DIR) else {
return Err("Failed to create executable directory.".to_string());
};

// 4. download executable
// 5. download executable
let binary_path = format!("{EXECUTABLE_DIR}/{}", asset.name);
if !std::fs::metadata(&binary_path).is_ok_and(|stat| stat.is_file()) {
zed::set_language_server_installation_status(
Expand All @@ -118,7 +118,7 @@ impl PathServerExtension {
return Err("Failed to make executable.".to_string());
};

// 5. clean up old versions
// 6. clean up old versions
let Ok(entries) = std::fs::read_dir(EXECUTABLE_DIR) else {
zed::set_language_server_installation_status(
language_server_id,
Expand Down Expand Up @@ -247,13 +247,16 @@ impl zed::Extension for PathServerExtension {

fn language_server_workspace_configuration(
&mut self,
_server_id: &zed::LanguageServerId,
server_id: &zed::LanguageServerId,
worktree: &zed::Worktree,
) -> zed::Result<Option<zed::serde_json::Value>> {
let settings = LspSettings::for_worktree("path-server", worktree)
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
.ok()
.and_then(|lsp_settings| lsp_settings.settings)
.unwrap_or_default();

// Convert configuration key into `path-server`
// See `config::get` in the path-server crate (src/config.rs)
Ok(Some(serde_json::json!({
"path-server": settings
})))
Expand Down
Loading