CI: add Go 1.27 to CI - #3070
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3070 +/- ##
==========================================
+ Coverage 93.34% 95.71% +2.36%
==========================================
Files 43 44 +1
Lines 4735 4035 -700
==========================================
- Hits 4420 3862 -558
+ Misses 192 173 -19
+ Partials 123 0 -123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aldas
requested changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LATEST_GO_VERSIONfrom Go 1.26 to Go 1.27.TestHandlerName_differentFuncSameName, which depends on compiler-generated closure symbol names.Background
Go 1.27 changed how function literals and closures are named by the compiler. A function literal now uses the same symbol name regardless of inlining, and multiple closure instances may share the same code and symbol name.
As a result, the following handlers:
previously had different names under older Go versions, but both resolve to the following name with Go 1.27:
This behavior is documented in the Go 1.27 release notes. The
reflect.Value.Pointerdocumentation also states that a function code pointer is not guaranteed to uniquely identify a function value.Test removal
TestHandlerName_differentFuncSameNameasserted exact compiler-generated names and required two closure instances to have different names. Neither behavior is guaranteed across Go versions, so the test has been removed.This part may need further discussion. If retaining coverage for closure handlers is preferred, the test could instead verify only version-independent behavior, such as:
HandlerNamereturns a non-empty value for a closure.It should not assert that separate closure instances have either equal or different names.
Verification
go test ./...with Go 1.27.0