Repository navigation
ci: pin validation Node patch across formal shards - #251
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 84 84
Lines 13026 13026
Branches 805 805
==========================================
- Hits 12333 12332 -1
- Misses 627 628 +1
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reported in the maintainer's session: full formal run 41452535665 could not merge passing Go mutation shards because floating Node 24 resolved to v24.22.1 on shard 1 and v24.22.0 on shard 11. Strict provenance correctly rejected the mismatch.
Change
Type: Tooling. Pin the shared setup-validation action to Node 24.22.1 so generation, replay, mutation shards and merge jobs use the same exact patch regardless of runner caches. Keep strict artifact provenance validation unchanged. Add a workflow-shape regression requiring an exact Node 24 patch and shared setup across formal jobs, without direct per-job setup-node overrides. No design record is needed; this restores reproducible tooling without changing conformance criteria. Release and consumer-floor versions are unchanged.
Open questions
Full verification is required for this language toolchain pin. The available GitHub connector has no workflow-dispatch action and the local gh CLI is unauthenticated; after PR CI passes, dispatch formal-full.yaml in full mode on this branch before leaving draft.
Validation
Head:
3e3fb23e239dae2fb1d06f7ef4bd985794f0e372bae1e5eplus test only: fails as expected because24is not an exact patch.corepack pnpm --dir typescript exec vitest run test/formal-validation.test.ts test/formal-mutation-shards.test.ts: 59 tests passed, including strict Node provenance rejection.corepack pnpm --dir typescript typecheck: passed.make audit: passed.git diff --check: passed; independent diff review found no blocking issues.Not run: PR CI pending creation; Full verification pending the dispatch access described above. Local focused checks do not substitute for either.
Follow-ups
None.