Skip to content

ci: pin validation Node patch across formal shards - #251

Merged
lan17 merged 1 commit into
mainfrom
fix/pin-validation-node-24-22-1
Nov 3, 2026
Merged

lan17 merged 1 commit into
mainfrom
fix/pin-validation-node-24-22-1

Conversation

@lan17

@lan17 lan17 commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Problem

Reported in the maintainer's session: full formal run 41452535665 could not merge passing Go mutation shards because floating Node 24 resolved to v24.22.1 on shard 1 and v24.22.0 on shard 11. Strict provenance correctly rejected the mismatch.

Change

Type: Tooling. Pin the shared setup-validation action to Node 24.22.1 so generation, replay, mutation shards and merge jobs use the same exact patch regardless of runner caches. Keep strict artifact provenance validation unchanged. Add a workflow-shape regression requiring an exact Node 24 patch and shared setup across formal jobs, without direct per-job setup-node overrides. No design record is needed; this restores reproducible tooling without changing conformance criteria. Release and consumer-floor versions are unchanged.

Open questions

Full verification is required for this language toolchain pin. The available GitHub connector has no workflow-dispatch action and the local gh CLI is unauthenticated; after PR CI passes, dispatch formal-full.yaml in full mode on this branch before leaving draft.

Validation

Head: 3e3fb23e239dae2fb1d06f7ef4bd985794f0e372

  • New regression on parent bae1e5e plus test only: fails as expected because 24 is not an exact patch.
  • Final tree: corepack pnpm --dir typescript exec vitest run test/formal-validation.test.ts test/formal-mutation-shards.test.ts: 59 tests passed, including strict Node provenance rejection.
  • Final tree: corepack pnpm --dir typescript typecheck: passed.
  • Final tree: make audit: passed.
  • Final tree: git diff --check: passed; independent diff review found no blocking issues.

Not run: PR CI pending creation; Full verification pending the dispatch access described above. Local focused checks do not substitute for either.

Follow-ups

None.

@codecov-commenter

codecov-commenter commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.67%. Comparing base (bae1e5e) to head (3e3fb23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   94.67%   94.67%   -0.01%     
==========================================
  Files          84       84              
  Lines       13026    13026              
  Branches      805      805              
==========================================
- Hits        12333    12332       -1     
- Misses        627      628       +1     
  Partials       66       66              
Flag Coverage Δ
go 93.25% <ø> (-0.05%) ⬇️
python 93.60% <ø> (ø)
rust 94.78% <ø> (ø)
typescript 97.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lan17
lan17 marked this pull request as ready for review November 3, 2026 00:48
@lan17
lan17 merged commit ef42157 into main Nov 3, 2026
21 checks passed
@lan17
lan17 deleted the fix/pin-validation-node-24-22-1 branch November 3, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants