Conversation
A batch_size of Some(0) passed to Dataset::add_columns or FileFragment::add_columns reached FragmentReader::read_all(0), whose system-column read path calls step_by(0) and panics. Through the Java bindings that panic crosses an extern "system" entrypoint and aborts the JVM instead of raising an input error. Reject it in Updater::try_new, which every add_columns transform and binding goes through, with an InvalidInput error.
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The zero batch size is now rejected as InvalidInput before fragment reads or writes, so Rust and binding callers cannot reach the step_by(0) panic. The shared updater guard covers the dataset and fragment data-rewriting paths, and the regression test exercises the public dataset path.
lance-gatekeeper
Bot
added
the
K-approved
wjones127
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch_size of Some(0) passed to Dataset::add_columns or FileFragment::add_columns reached FragmentReader::read_all(0), whose system-column read path calls step_by(0) and panics. Through the Java bindings that panic crosses an extern "system" entrypoint and aborts the JVM instead of raising an input error.
Reject it in Updater::try_new, which every add_columns transform and binding goes through, with an InvalidInput error.